Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl3 switch #171

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Openssl3 switch #171

merged 1 commit into from
Aug 3, 2023

Conversation

hbeni
Copy link
Owner

@hbeni hbeni commented Jul 31, 2023

Switch to OpenSSL3 for all builds

  • linux built natively, dynamically linked

  • macOS built natively, dynamically linked

    • This should work at MacOS >= 13 (with libreSSL?), since 12 only ships OSSL 1.1
    • Statically building openssl under macOS is currently unsupported, afaik
    • has a brew receipe for MacOS 10,11,12: https://formulae.brew.sh/formula/openssl@3
      (maybe we should switch to that instead of "selfcompiling our" openssl, so we get more assurance that users can brew install openssl on their systems?)
    • 🆘 🧪 untested, but builds (help wanted: I have no mac to test with!)
  • windows 32/64 built with mingw, statically linked

  • upgrade the HTTP client too. The linker gives some deprecated warnings already.


closes #170

@hbeni hbeni added the mumble-plugin Affecting mumble plugin label Jul 31, 2023
@hbeni hbeni self-assigned this Jul 31, 2023
@hbeni hbeni marked this pull request as draft July 31, 2023 06:20
@hbeni hbeni force-pushed the Issue-170_OpenSSL3 branch 3 times, most recently from e82886a to 46febfd Compare July 31, 2023 08:17
@hbeni
Copy link
Owner Author

hbeni commented Jul 31, 2023

At least builds now.

  • ✔️ Linux: loads
  • ✔️ Windows: loads
  • MacOS: untested, but builds (:sos: help wanted: I have no mac to test with!)

@hbeni
Copy link
Owner Author

hbeni commented Jul 31, 2023

One thing to think about.... is version incompatibility
It seems MacOS moved from OpenSSL to LibreSSL with 12 ("Ventura", released 24.10.2022).
So if we decide to build against the "shipped" SSL library, we should migrate the build over to libressl instead of the brew thingy.
Doing this will make the affected plugin version incompatible with macOS <12.
⚠️ I'm not yet sure if that openssl->libressl change is just on github, or generally in macOS.

Same seems to be true for linux distros (at least debian, which ships openssl 3 from Debian 12 "bookworm" onwards, which went stable at 10.06.2023)


ℹ️ Maybe a good solution is to keep this branch up-to-date for some time so we can provide builds against openssl3 on demand. After a while we might merge it and introduce that downward-breaking change to master; which will pin users to the previous release.
ℹ️ ☝️ So a good approach might be to have a release with OpenSSL 1, immediately followed by a release against openssl3; without changing the plugins version number (so the updater does not complain).

@hbeni hbeni marked this pull request as ready for review August 1, 2023 08:39
@hbeni hbeni merged commit 1e44a9a into master Aug 3, 2023
4 checks passed
@hbeni hbeni deleted the Issue-170_OpenSSL3 branch August 3, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mumble-plugin Affecting mumble plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch release build to OpenSSL 3.0.0
1 participant