-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create Data interface #11
create Data interface #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dictionary/controller/dictionary.go
Line 62 in e21cf66
func (f *dictHandler) ApiITJapanWonderWord(c echo.Context) error { |
Em sửa tiếp sao cho hàm này cũng gọi được thông qua getDataJapanese
nhé
|
||
type MakeData func(c *html.Node, idx int, option ...string) Data | ||
|
||
func MakeWord(c *html.Node, index int, options ...string) Data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check length của options
trước khi access để tránh lỗi panic index out of range
Co-authored-by: hbl-ngocnd1 <106229363+hbl-ngocnd1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.