rename "device" to "adapter"

[dlech]

• bleak version: develop
• Python version: N/A
• Operating System: N/A
• BlueZ version (bluetoothctl -v) in case of Linux: N/A

Description

There are places in the code where we use a device keyword argument to specify the the Bluetooth adapter to use to connect to a Bluetooth device.

I find this rather confusing since the term "device" is used in most places to mean a remote Bluetooth device. The term "adapter" seems to be the standard nomenclature for the local Bluetooth radio.

It would be nice to rename this argument to be less confusing. We can still check for the old name too so that we don't break existing code.

[dhalbert]

Here is some previous related discussion: #285 (comment)

[hbldh]

Yes, I agree. I do not know why I used device in the first place. I ought to have used adapter, as was used in e.g. gatttool which I used prior to this, but it seems I confused the two somehow while implementing.

The #360 is a current issue related to this. This row should be changed to

scanner = cls(timeout=timeout, **kwargs)

to be able to connect with anything else than hci0. Had it been called adapter from the start, I don't think this would have slipped past...