-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backends/winrt: don't throw exception for properly configured GUI apps #1581
Merged
Commits on May 23, 2024
-
backends/winrt: don't throw exeception for properly configued GUI apps
In commit 4a653e6 ("backends/winrt: raise exception when trying to scan with STA") we added a check to raise an exception when trying to scan when PyWinRT set the aparatment model to STA. However, properly working GUI apps will have the apartment model set to STA but Bleak will still work because there is something pumping the Windows message loop. We don't want to raise an exception in this case to avoid breaking working apps. We can improve the test by checking if the current thread is actually pumping the message loop by scheduling a callback via a the win32 SetTimeout function. If the callback is called, then we know that the message loop is being pumped. If not, then we probably are not going to get async callbacks from the WinRT APIs and we raise an exception in this case.
Configuration menu - View commit details
-
Copy full SHA for 69b8c69 - Browse repository at this point
Copy the full SHA 69b8c69View commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 45cab2d - Browse repository at this point
Copy the full SHA 45cab2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59a4fbb - Browse repository at this point
Copy the full SHA 59a4fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26a7893 - Browse repository at this point
Copy the full SHA 26a7893View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef0723f - Browse repository at this point
Copy the full SHA ef0723fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b48574 - Browse repository at this point
Copy the full SHA 2b48574View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6c49f - Browse repository at this point
Copy the full SHA 2b6c49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3685a2 - Browse repository at this point
Copy the full SHA d3685a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c987aaa - Browse repository at this point
Copy the full SHA c987aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f88e87 - Browse repository at this point
Copy the full SHA 1f88e87View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9eeb0c - Browse repository at this point
Copy the full SHA c9eeb0cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.