Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device info bluezdbus client.py #346

Merged
merged 12 commits into from
Oct 22, 2020

Conversation

Carglglz
Copy link
Contributor

I may be wrong, but currently there is no way to retrieve device information (name, RSSI...) in Bluezdbus client.
This adds client._device_info, similar to CoreBluetooth client.

@hbldh
Copy link
Owner

hbldh commented Oct 22, 2020

Is this really useful information? The information there that is interesting, e.g. RSSI, is not updated, so it will be just device name and suchlikes. In my world, that is information you don't need after connection, but that is just me.

Try to make PRs from pristine branches so that only one commit exists. This I will have to squash and merge and I like to avoid doing that.

@hbldh hbldh merged commit a1d0f53 into hbldh:develop Oct 22, 2020
@Carglglz Carglglz deleted the add-device-info-linux branch October 22, 2020 13:29
@Carglglz
Copy link
Contributor Author

Try to make PRs from pristine branches so that only one commit exists. This I will have to squash and merge and I like to avoid doing that.

Sorry a I didn't realise of this mess yesterday 😞, I was about to close this and make a proper PR.

Is this really useful information? The information there that is interesting, e.g. RSSI, is not updated, so it will be just device name and suchlikes. In my world, that is information you don't need after connection, but that is just me.

I do use the Name and suchlike to set further configuration, and since this was already in CoreBluetooth client + being that the change was only 3 lines I though this would be harmless.

So thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants