Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Multiple Device Troubleshooting Section #755

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Add a Multiple Device Troubleshooting Section #755

merged 3 commits into from
Feb 10, 2022

Conversation

cooperlees
Copy link
Contributor

  • Add information / tips to help with:
    • Connection issues to multiple devices
    • Pass more parameters to notify callback function

Fixes #754

- Add information / tips to help with:
  - Connection issues to multiple devices
  - Pass more parameters to notify callback function

Fixes #754
@dlech
Copy link
Collaborator

dlech commented Feb 6, 2022

Add information / tips to help with:
* Connection issues to multiple devices
* Pass more parameters to notify callback function

This seems like two unrelated problems, so I would expect two separate sections in the docs.

  • Pass more parameters to notify callback function

I'm wondering if we should fix this in code instead of "fixing" it in documentation. See my previous comment at #754 (comment).

@dlech
Copy link
Collaborator

dlech commented Feb 6, 2022

  • Pass more parameters to notify callback function

I'm wondering if we should fix this in code instead of "fixing" it in documentation. See my previous comment at #754 (comment).

I opened #759 to discuss this separately.

@cooperlees
Copy link
Contributor Author

My goal was not to "fix" here, but to possibly save someone the hours and hours this cost me until the better action, something like #759 is complete.

It's not very clear, are you interested in improving the docs here or do you want to leave this not addresses and just fix the API to handle this? Your response is not very clear and easy to interpret to action(s).

@dlech
Copy link
Collaborator

dlech commented Feb 7, 2022

OK, I will try again.

Add information / tips to help with:

  • Connection issues to multiple devices
  • Pass more parameters to notify callback function

This seems like two unrelated problems, so I would expect two separate sections in the docs.

These are two unrelated issues, so combining them into one troubleshooting section seems like it would make it harder to find the answer for one or the other.

  • Connection issues to multiple devices

There is no debate about this issue. Having a troubleshooting section that explains that you should use a separate BleakScanner to scan first and then stop scanning before attempting to connect when you have multiple devices sounds like a good idea to me. This applies to multiple devices in general, not just ones with the same service uuids.

  • Pass more parameters to notify callback function

I don't have a strong opinion one way or the other if we include this now or wait to see what the resolution of #759 is. But if we include it now, it should be a separate section from the scanning issue.

Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. I just have a few suggestions.

docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
@dlech dlech merged commit feee9d6 into hbldh:develop Feb 10, 2022
@dlech
Copy link
Collaborator

dlech commented Feb 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect notify data from two devices (different MACs) with same UUIDs + Identify devices
2 participants