Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make callback logging lazy #912

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Make callback logging lazy #912

merged 1 commit into from
Aug 1, 2022

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Aug 1, 2022

Fixes logging-format-interpolation (W1202)

Fixes __repr__ being called and thrown away
Screen Shot 2022-07-31 at 4 06 25 PM

Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please add a changelog entry? Also it would be nice to change the commit message to explain this only changes one instance in the bluez backend (there are many other callbacks that could use the same fix).

@bdraco
Copy link
Contributor Author

bdraco commented Aug 1, 2022

Will fix it when I get back home, looks like I forgot to push or commit since I remember writing it 🤦‍♂️

@bdraco
Copy link
Contributor Author

bdraco commented Aug 1, 2022

Sorry about that. I had pushed it to the wrong remote and didn't notice it rejected

CHANGELOG.rst Outdated Show resolved Hide resolved
Fixes logging-format-interpolation (W1202)
Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlech dlech merged commit 742b63d into hbldh:develop Aug 1, 2022
@dlech dlech mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants