Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from dbus_next to dbus_fast #988

Merged
merged 11 commits into from
Sep 10, 2022
Merged

Switch from dbus_next to dbus_fast #988

merged 11 commits into from
Sep 10, 2022

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Sep 9, 2022 •
edited
Loading

Removes workaround since .disconnect() now closes the socket and fixes the leak.

@bdraco
Copy link
Contributor Author

bdraco commented Sep 9, 2022

I think this is ready do go. I just have to retest every device I have which will take an hour or so

@bdraco bdraco marked this pull request as ready for review September 9, 2022 22:36
dlech
dlech reviewed Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the work on this!

CHANGELOG.rst Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@dlech dlech merged commit f8f3125 into hbldh:develop Sep 10, 2022
@dlech dlech mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlech dlech dlech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdraco @dlech