- Experimental verification of BankID signatures #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not yet write unittest because I have a weird complication with pytest locally. |
hbldh
requested changes
Sep 24, 2018
There was a problem hiding this comment.
Nice, I will look at it during this week.
I saw one thing I would like to change immediately though: move the packages added in requirements.txt to an extras in setup.py. Then the extra packages will be installed via calling pip install pybankid[name_of_your_choosing] instead of by default to all users who use the requirements file.
|
Sounds good, as I said it is very experimental and mainly a fist attempt to get something rolling so it's definitely not intended as a merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.