New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy vectorized efd #2
Conversation
This is very nice! Something I should have done when converting the Matlab code and never got around to doing. I will merge this tomorrow to version 1.30, and later on fix the CI kerfuffle. Thank you very much! |
Hi @hbldh I added a few commits to make the tests pass. I removed testing for python versions 3.3 and 2.6, which is necessary to run the tests on an image that allows testing for python 3.6 and 3.7, versions that are much more likely to be in current use. Adding tests on python 3.7 requires the Hope you approve! |
I appreciate the Travis fixes: I am trying to migrate from Travis to Azure Pipelines whenever I do a new release of a project now, so there is some extra work to be done before I am done. 2.6, 3.3, 3.4 is more than fine to drop. This code is now included in the 1.3.0 release on PyPI. Thanks once again! |
Great! |
Numpy vectorized refactoring of efd function. Includes test for 3-4 times performance increase.
Thanks for sharing your code!