Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy vectorized efd #2

Merged
merged 8 commits into from Jun 18, 2019
Merged

Numpy vectorized efd #2

merged 8 commits into from Jun 18, 2019

Conversation

reinvantveer
Copy link
Contributor

Numpy vectorized refactoring of efd function. Includes test for 3-4 times performance increase.

Thanks for sharing your code!

@coveralls
Copy link

coveralls commented Jun 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 1df8168 on SPINLab:numpy_vectorized_efd into 5c4e880 on hbldh:master.

@hbldh
Copy link
Owner

hbldh commented Jun 17, 2019

This is very nice! Something I should have done when converting the Matlab code and never got around to doing. I will merge this tomorrow to version 1.30, and later on fix the CI kerfuffle. Thank you very much!

@reinvantveer
Copy link
Contributor Author

reinvantveer commented Jun 18, 2019

Hi @hbldh I added a few commits to make the tests pass. I removed testing for python versions 3.3 and 2.6, which is necessary to run the tests on an image that allows testing for python 3.6 and 3.7, versions that are much more likely to be in current use.

Adding tests on python 3.7 requires the dist: xenial option (see docs), but there's no support for python 2.6 there. On the flipside, current pytest has no support for python 3.3 or 2.6 anymore (see pypi/pytest. So I took the liberty to ditch 3.3 and 2.6.

Hope you approve!

@hbldh hbldh merged commit 95630e1 into hbldh:master Jun 18, 2019
@hbldh hbldh self-assigned this Jun 18, 2019
@hbldh
Copy link
Owner

hbldh commented Jun 18, 2019

I appreciate the Travis fixes: I am trying to migrate from Travis to Azure Pipelines whenever I do a new release of a project now, so there is some extra work to be done before I am done.

2.6, 3.3, 3.4 is more than fine to drop.

This code is now included in the 1.3.0 release on PyPI. Thanks once again!

@reinvantveer reinvantveer deleted the numpy_vectorized_efd branch June 19, 2019 12:41
@reinvantveer
Copy link
Contributor Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants