repo: Improve handling of offline repos. Fixes #439

hbons · Dec 3, 2011 · c01c852 · c01c852
1 parent d83df10
commit c01c852
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/SparkleLib/Git/SparkleRepoGit.cs b/SparkleLib/Git/SparkleRepoGit.cs
@@ -137,10 +137,12 @@ public override bool CheckForRemoteChanges ()
 
         public override bool SyncUp ()
         {
-            Add ();
+            if (AnyDifferences) {
+                Add ();
 
-            string message = FormatCommitMessage ();
-            Commit (message);
+                string message = FormatCommitMessage ();
+                Commit (message);
+            }
 
             SparkleGit git = new SparkleGit (LocalPath, "push origin master");
             git.Start ();

diff --git a/SparkleLib/SparkleRepoBase.cs b/SparkleLib/SparkleRepoBase.cs
@@ -116,7 +116,7 @@ public SparkleRepoBase (string path, SparkleBackend backend)
 
                 // In the unlikely case that we haven't synced up our
                 // changes or the server was down, sync up again
-                if (HasUnsyncedChanges)
+                if (HasUnsyncedChanges && !IsSyncing && this.server_online)
                     SyncUpBase ();
             };
 
@@ -180,7 +180,7 @@ protected void OnConflictResolved ()
         }
 
 
-        public virtual bool CheckForRemoteChanges () // HasRemoteChanges { get; } ?
+        public virtual bool CheckForRemoteChanges () // TODO: HasRemoteChanges { get; }
         {
             return true;
         }
@@ -432,8 +432,9 @@ private void SyncUpBase ()
 
                     HasUnsyncedChanges = true;
                     SyncDownBase ();
+                    DisableWatching ();
 
-                    if (SyncUp ()) {
+                    if (this.server_online && SyncUp ()) {
                         HasUnsyncedChanges = false;
 
                         if (SyncStatusChanged != null)
@@ -442,6 +443,8 @@ private void SyncUpBase ()
                         this.listener.AnnounceBase (new SparkleAnnouncement (Identifier, CurrentRevision));
 
                     } else {
+                        this.server_online = false;
+
                         if (SyncStatusChanged != null)
                             SyncStatusChanged (SyncStatus.Error);
                     }