Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use general preferredName / variantName properties #3

Closed
acka47 opened this issue Jul 4, 2017 · 2 comments
Closed

Use general preferredName / variantName properties #3

acka47 opened this issue Jul 4, 2017 · 2 comments
Assignees

Comments

@acka47
Copy link
Contributor

@acka47 acka47 commented Jul 4, 2017

From #1:

We don't want specific name properties like preferredNameForThePlaceOrGeographicName and variantNameForThePlaceOrGeographicName. For all entities, we should just use preferredName and variantName.

This will allow us to query the whole data in a uniform way. (The type is made clear by other means so that we don't need the specific properties.)

@acka47 acka47 changed the title Use general property for labels Use general preferredName / variantName properties Jul 4, 2017
@acka47 acka47 added the ready label Jul 4, 2017
@fsteeg fsteeg removed the ready label Jul 19, 2017
@fsteeg fsteeg added ready and removed ready labels Aug 10, 2017
@fsteeg
Copy link
Member

@fsteeg fsteeg commented Aug 14, 2017

Deployed to test: http://test.lobid.org/authorities/4074335-4.json

(@ChristophEwertowski: We have no production system yet, so just +1 and close if this looks good.)

@fsteeg fsteeg added review and removed working labels Aug 14, 2017
@fsteeg fsteeg assigned ChristophEwertowski and unassigned fsteeg Aug 14, 2017
@ChristophEwertowski
Copy link
Contributor

@ChristophEwertowski ChristophEwertowski commented Aug 14, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants