Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBS-derived entries missing "Regionalschlüssel" #90

Closed
acka47 opened this issue Dec 17, 2015 · 5 comments · Fixed by #115
Closed

DBS-derived entries missing "Regionalschlüssel" #90

acka47 opened this issue Dec 17, 2015 · 5 comments · Fixed by #115
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Dec 17, 2015

From #89 (comment):

For some DBS-derived entries, the base data has a "Regionalschlüssel" in it, it can not be found in the RDF, though, and probably isn't used for matching with Geo Names.

This is all quite strange. I will investigate this sometimes in 2016...

@acka47
Copy link
Contributor Author

acka47 commented Mar 8, 2016

I took a look at the source DBS csv file. Actually, nearly every entry has a regionalschlüssel in it. I wanted to present some functions using the "rs" or "ags" field in our webcast tomorrow but won't do it as the necessary data isn't there...

@acka47 acka47 assigned fsteeg and unassigned acka47 Mar 8, 2016
@acka47
Copy link
Contributor Author

acka47 commented Mar 8, 2016

I think, I found the problem. Actually, the Regionalschlüssel from DBS isn't taken into account at all. In the morph the field where the key comes from is name "gemeindekennzahl", see

<data source="gemeindekennzahl" name="rs">
<regexp match="(\d{11})" format="0${1}"/>
</data>
<data source="gemeindekennzahl" name="rs">
. In the csv file that is transformed the relevant field is named "stk_2007".

@acka47 acka47 added the ready label Mar 8, 2016
@fsteeg fsteeg added working and removed ready labels Mar 8, 2016
@fsteeg
Copy link
Member

fsteeg commented Mar 8, 2016

Deployed to staging: http://test.lobid.org/organisations/search?q=dbsID:*+AND+rs:*

I also changed what I believe was a bug in the previous version: if the DBS stk_2007 is 11 digits, a 0 is prependend (this wasn't actually working before). If it's 12 digits, it's used as it is. Does that make sense?

@acka47
Copy link
Contributor Author

acka47 commented Mar 8, 2016

I also changed what I believe was a bug in the previous version: if the DBS stk_2007 is 11 digits, a 0 is prependend (this wasn't actually working before).

Hmm, @SBRitter and me did some work on the "rs" (Regionalschlüssel). In fact, it really has to have 12 digits, see https://de.wikipedia.org/wiki/Amtlicher_Gemeindeschl%C3%BCssel#Regionalschl.C3.BCssel. For today, I can not dig deeper into this.

Didn't find an error in th examples I looked at, so: +1

@acka47 acka47 assigned fsteeg and unassigned acka47 Mar 8, 2016
@fsteeg
Copy link
Member

fsteeg commented Mar 8, 2016

Yes, it looked like it was meant to be implemented that way, but due to an ordering bug it was not actually working (0 was prepended to 12 digit values, last digit was cut off).

@fsteeg fsteeg added deploy and removed review labels Mar 8, 2016
@fsteeg fsteeg closed this as completed in 46b8ee5 Mar 9, 2016
@fsteeg fsteeg removed the deploy label Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants