Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context keywords for consistency #156

Closed
fsteeg opened this issue Jan 9, 2017 · 3 comments
Closed

Update context keywords for consistency #156

fsteeg opened this issue Jan 9, 2017 · 3 comments
Assignees
@dr0i

Comments

@fsteeg
Copy link
Member

fsteeg commented Jan 9, 2017 •
edited by ChristophEwertowski

Originally came up in #132 (comment), @acka47 mentioned offline that there are more such cases. Starting the list:

  • describedby -> describedBy (as in exemplarOf)
@fsteeg fsteeg mentioned this issue Jan 9, 2017
Closed
@fsteeg fsteeg added the ready label Jan 9, 2017
@ChristophEwertowski ChristophEwertowski mentioned this issue Jan 10, 2017
Closed
@acka47
Copy link
Contributor

acka47 commented Jan 10, 2017 •
edited

@acka47 mentioned offline that there are more such cases

I think I mixed this up with lobid vocab where we also don't use camel case consistently (contactqr, dbsID, fundertype, hbzID, nwbibsubject, nwbibspatial, stocksize). However, here are three more keywords that could be improved in the lobid-resources JSON-LD context:

nwbibspatial -> nwbibSpatial
nwbibsubject -> nwbibSubject
oclcnum -> oclcNumber

@ChristophEwertowski ChristophEwertowski self-assigned this Jan 23, 2017
ChristophEwertowski added a commit that referenced this issue Jan 23, 2017
@ChristophEwertowski
Change context keywords to camel case
59b8387 
See #156
@ChristophEwertowski
Copy link
Contributor

Context keywords updated in branch.
@dr0i : If it's no great annoyance please update the lobid vocab so I can update the URIs of nwbibSpatial and nwbibSubject. I'd like to do it in one issue/pull request.

@acka47
Copy link
Contributor

acka47 commented Jan 23, 2017

I don't think we need to update the vocab. We might break things doing this. The vocab is in the repo https://github.com/lobid/vocabs. You might open an issue there for discussion.

This was referenced Jan 24, 2017
Closed
Merged
@dr0i dr0i added working and removed review labels Jan 27, 2017
dr0i added a commit that referenced this issue Jan 27, 2017
@dr0i
Merge branch '156-updateContextKeywords' of https://github.com/hbz/lo…
fb8774c 
…bid-resources into mergeBranch

Resolves #156.
@ChristophEwertowski ChristophEwertowski removed their assignment Jan 31, 2017
fsteeg added a commit that referenced this issue Jan 31, 2017
@fsteeg
Fit map bounds to current location (see #74, #156)
fecaf59
@dr0i dr0i closed this as completed in #188 Jan 31, 2017
@dr0i dr0i removed the deploy label Jan 31, 2017
ChristophEwertowski added a commit that referenced this issue Mar 31, 2017
@ChristophEwertowski
Change describedby to camelCase describedBy
942d90d 
Resolves #358
Also see #156. Few indents for beauty reasons.
@ChristophEwertowski ChristophEwertowski mentioned this issue Mar 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fsteeg @acka47 @dr0i @ChristophEwertowski