Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong facets for multi word queries #278

Closed
fsteeg opened this issue Mar 1, 2017 · 8 comments
Closed

Wrong facets for multi word queries #278

fsteeg opened this issue Mar 1, 2017 · 8 comments
Assignees
Labels

Comments

@fsteeg
Copy link
Member

fsteeg commented Mar 1, 2017

http://lobid.org/resources/search?q=ehrenfeld+nubbel

Facets shown would be correct for just querying 'ehrenfeld'.

@fsteeg fsteeg self-assigned this Mar 1, 2017
@fsteeg fsteeg added working and removed ready labels Mar 1, 2017
@fsteeg
Copy link
Member Author

fsteeg commented Mar 1, 2017

It's actually not the counts that are wrong, but the searches linked from the facets.

@fsteeg
Copy link
Member Author

fsteeg commented Mar 1, 2017

@ChristophEwertowski
Copy link
Contributor

ChristophEwertowski commented Mar 1, 2017

Doesn't work for libraries: For example, if you select the facet "Köln USB" after executing the search above you get 298 hits while the facet counts 334 (staging and productive).
For the rest: +1

@acka47
Copy link
Contributor

acka47 commented Mar 1, 2017

Doesn't work for libraries: For example, if you select the facet "Köln USB" after executing the search above you get 298 hits while the facet counts 334

I think we already had this in the past. Isn't the underlying mechanism that the facet gives the number of items while the query result lists the FRBR manifestations (or in bibframe-speak: instances)? This would mean there are 36 dublicate items...

A good example is the setting the holding facet on "Bibliothek des Ruhrgebiets". You get only three examples but the facet count says "44". When you take a look at the resource "Die Ehrenfelder" you see that a lot of items are connected with it.

@acka47
Copy link
Contributor

acka47 commented Mar 1, 2017

@fsteeg I don't know how this count is implemented? Could you just count distinct entries in the itemOf field of the items in question?

@ChristophEwertowski
Copy link
Contributor

Shouldn't we have the discussion why it doesn't work in #207 ?

@fsteeg
Copy link
Member Author

fsteeg commented Mar 1, 2017

I'll look into the owner issue, but since it is unrelated to this issue (which affects all facets, and much more severly) I second @ChristophEwertowski's suggestion to discuss this in #207. Will reopen that.

@acka47
Copy link
Contributor

acka47 commented Mar 2, 2017

+1

@acka47 acka47 removed their assignment Mar 2, 2017
@fsteeg fsteeg added deploy and removed review labels Mar 2, 2017
@fsteeg fsteeg closed this as completed in a2da9c9 Mar 2, 2017
@fsteeg fsteeg removed the deploy label Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants