Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding publication types "Statistics" and "Standards" #531

Closed
ChristophEwertowski opened this issue Jul 26, 2017 · 4 comments
Closed

Adding publication types "Statistics" and "Standards" #531

ChristophEwertowski opened this issue Jul 26, 2017 · 4 comments
Assignees
@dr0i

Comments

@ChristophEwertowski
Copy link
Contributor

An edoweb customer wants the publication types "Statistics" and "Standards". From the Jira ticket:

Bitte Aleph 051 mn bzw. sn unter Publikationstyp "Leitlinien / Normschriften" zusammenfassen, 051 ms bzw. ss unter "Statistiken"

I have to think / read about the most precise English term. Of course we should type resources with other "Erscheinungsformen" also as the same type.
@ChristophEwertowski ChristophEwertowski self-assigned this Jul 26, 2017
@acka47
Copy link
Contributor

acka47 commented Jul 26, 2017

We already have Standard as type, see http://lobid.org/resources/search?q=type:Standard and lines 615-620 of the current morph.

@ChristophEwertowski
Copy link
Contributor Author

Deployed to test, see HT018722247 (json) (publication type "Statistic") and HT019072754 (publication type "Standard" which wasn't included in the set of example resources).
If it's deployed to production we should also add facets for Statistic and Standard (which now has 1412 resources).

ChristophEwertowski added a commit that referenced this issue Jul 26, 2017
@ChristophEwertowski
Add publication type statistic, also add HT018722247 and HT019072754
8c1d6bf 
HT018722247: Changed resource to statistic (MAB 051).
HT019072754: Changed resource to norm (MAB 051). No resources yet in
 collection which is typed "standard".
Also sorted context and morph a bit.

See #531
@ChristophEwertowski ChristophEwertowski mentioned this issue Jul 26, 2017
Merged
ChristophEwertowski added a commit that referenced this issue Jul 26, 2017
@ChristophEwertowski
Add publication type statistic, also add HT018722247 and HT001039253
0213c45 
HT018722247: Changed resource to statistic (MAB 051).
HT001039253: No resources yet in collection which is typed "standard".
Also sorted context and morph a bit.

See #531
@ChristophEwertowski
Copy link
Contributor Author

Updated to include HT001039253 (json) instead of HT019072754. HT019072754 was a resource by the customer but didn't include 051..s so I changed it manually.

@acka47
Copy link
Contributor

acka47 commented Jul 27, 2017 •
edited

As discussed offline, we will use the plural "Statistics". Otherwise, +1.

@acka47 acka47 assigned ChristophEwertowski and unassigned acka47 Jul 27, 2017
ChristophEwertowski added a commit that referenced this issue Jul 27, 2017
@ChristophEwertowski
Add publication type statistic, also add HT018722247 and HT001039253
c14496f 
HT018722247: Changed resource to statistic (MAB 051).
HT001039253: No resources yet in collection which is typed "standard".
Also sorted context and morph a bit.

See #531
This was referenced Aug 10, 2017
Closed
Closed
ChristophEwertowski added a commit that referenced this issue Aug 24, 2017
@ChristophEwertowski
Add publication type statistic, also add HT018722247 and HT001039253
7fadd67 
HT018722247: Changed resource to statistic (MAB 051).
HT001039253: No resources yet in collection which is typed "standard".
Also sorted context and morph a bit.

See #531
ChristophEwertowski added a commit that referenced this issue Aug 24, 2017
@ChristophEwertowski
Add publication type statistic, also add HT018722247 and HT001039253
7de4e12 
HT018722247: Changed resource to statistic (MAB 051).
HT001039253: No resources yet in collection which is typed "standard".
Also sorted context and morph a bit.

See #531
@dr0i dr0i assigned dr0i and unassigned ChristophEwertowski Aug 24, 2017
@dr0i dr0i added deploy and removed review labels Aug 24, 2017
dr0i pushed a commit that referenced this issue Aug 25, 2017
Merge branch '531-addPublicationTypeStatistic' of https://github.com/…
b389b25 
…hbz/lobid-resources

Resolves #531.

Conflicts:
	src/main/resources/morph-hbz01-to-lobid.xml
	src/test/resources/hbz01XmlClobs.tar.bz2
@dr0i dr0i closed this as completed in #533 Aug 28, 2017
@dr0i dr0i removed the deploy label Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acka47 @dr0i @ChristophEwertowski