Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also pull Prussian districts from Wikidata for matching #854

Merged
merged 3 commits into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@acka47
Copy link
Contributor

commented Jun 25, 2018

See #627 (comment)

@dr0i I also adjusted the code so that entries with notations 97 are also matched with the prussian districts. I hope I did it correctly.

@acka47 acka47 added the review label Jun 25, 2018

@dr0i

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

Looks good.
Going to deploy to stage and let's see if it works.

@dr0i dr0i added deploy and removed review labels Jun 26, 2018

@dr0i

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

New index is built. It has around 40 more entries than the old index.

@@ -70,7 +70,7 @@

{
put("99", "Q22865 Q262166 Q253019 Q1852178 Q15632166");
put("97", "Q106658");
put("97", "Q106658 Q5283531");
put("96", "Q829277");
put("36", "Q3146899 Q2072238");
put("97", "Q106658");

This comment has been minimized.

Copy link
@dr0i

dr0i Jun 29, 2018

Contributor

Oh, there are two entries of 97, which is not good. As long as the entries are same this doesn't have an effect. Now, as they are different, it does behave differently - it overwrites the first entry with the second entry, ignoring "Q5283531".

@dr0i dr0i added working and removed deploy labels Jun 29, 2018

@dr0i

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

I was wondering why e.g. https://www.wikidata.org/wiki/Q1787322 wasn't enriched. There is a bug in defining 97 two times, effectively ignoring the Prussian districts (Q5283531). Will add a fix.

@dr0i dr0i added deploy and removed working labels Jun 29, 2018

@dr0i dr0i merged commit 0a64356 into master Jul 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dr0i dr0i removed the deploy label Jul 2, 2018

@dr0i

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2018

@dr0i dr0i deleted the 627-wikidataMatching branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.