Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust configuration of types re. changes in lobid API 2.0. #360

Merged
merged 3 commits into from Dec 7, 2016

Conversation

acka47
Copy link
Contributor

@acka47 acka47 commented Dec 6, 2016

Fixes #359. See hbz/lobid-rdf-to-json#26 for the background.

@fsteeg
Copy link
Member

fsteeg commented Dec 7, 2016

Deployed to staging: https://test.nwbib.de/HT019093814

(Tests needed updates for the config changes, see a579f22)

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Dec 7, 2016
@acka47
Copy link
Contributor Author

acka47 commented Dec 7, 2016

Looks good in detail views but the publication type icons are now missing in result lists, see e.g. https://test.nwbib.de/search?q=

@acka47 acka47 assigned fsteeg and unassigned acka47 Dec 7, 2016
@fsteeg
Copy link
Member

fsteeg commented Dec 7, 2016

Oh, right. That's because the search still uses Lobid 1.x, which contains the full URI types. Hm.

@fsteeg
Copy link
Member

fsteeg commented Dec 7, 2016

We'll have to duplicate the config for the old and the new type values, I'll look into a way to do this.

This, like #354, shows that we should probably start working on #262 rather sooner than later.

@fsteeg
Copy link
Member

fsteeg commented Dec 7, 2016

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Dec 7, 2016
@acka47
Copy link
Contributor Author

acka47 commented Dec 7, 2016

+1

@acka47 acka47 assigned dr0i and unassigned acka47 Dec 7, 2016
@dr0i
Copy link
Member

dr0i commented Dec 7, 2016

+1

@dr0i dr0i assigned fsteeg and unassigned dr0i Dec 7, 2016
@dr0i dr0i added deploy and removed review labels Dec 7, 2016
@fsteeg fsteeg merged commit e2e626c into master Dec 7, 2016
@fsteeg fsteeg removed the deploy label Dec 7, 2016
@acka47 acka47 deleted the 359-fixTypes branch October 1, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants