Ensure create item always has correct tab index #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that my code has some redundant complexity. Let me clean this up first |
MegaKeegMan
force-pushed
the
592-fix-for-disabled-select-all
branch
from
0e8c184
to
de0bd6a
Compare
|
Haha wow it was so much simpler than I was making it. Anyway, it's ready. This will need to be updated when we decide to make the create option available even when there are results showing in the search filter. |
|
@MegaKeegMan Thanks for the PR, I'll just test this and merge today |
harshzalavadiya
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...even when select all is disabled
I think everything should work now
Ref #592