New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distance approximations of expected value are outside default approx envelope for pytest #6

Closed

hcarter333 opened this issue Jan 25, 2024 · 0 comments

Assignees

Owner

hcarter333 commented Jan 25, 2024 •

edited

Loading

The comparisions did not pass to one part in a million:

FAILED tests/test_haversine_point_path.py::test_haversine[float-ft-5805047] - assert 5805047 == 5796584.922005589 ± 5.8e+00
FAILED tests/test_haversine_point_path.py::test_haversine[float-m-1769378.36] - assert 1769378.36 == 1766799.08422737 ± 1.8e+00
FAILED tests/test_haversine_point_path.py::test_haversine[float-in-69660567] - assert 69660567 == 69559019.06407061 ± 7.0e+01

This is due entirely to the fact that I measured the distance by hand using google maps. I'm goin to turn the rel value down to 1e-3.

The text was updated successfully, but these errors were encountered:

hcarter333 self-assigned this

hcarter333 added a commit that referenced this issue


          Turns down accuracy on approximation for #6

d668eb6

hcarter333 closed this as completed in

920750f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment