-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hideCurrentSnackBar for showing instantly #15
Conversation
This seems to make total sense. Please, add a test and take a look at my comment so I can accept your PR :) |
@jja08111 I'm not quite sure what you're doing here. This repo already has a workflow to run the tests. |
@hugocbpassos Sorry, I didn't know how to test the PR. |
@jja08111 That's not what I meant by "add a test". My apologies. I want you to write a new test in test/double_back_to_close_app_test.dart which proofs that, when there's another snack-bar currently visible, this widget hides it out and shows up the snack-bar provided to If you are not really used to Flutter's testing framework, I can work on those tests for you in the weekend :) |
Note to myself: Those commits about the workflow must vanish, so in order to avoid having to rewrite git's history or resubmitting the PR, I should squash before merging. |
I fixed some conflicts caused by #16. |
I added the test so this should be good to go. Thanks for opening this PR :) |
If diffrent snackBar is shown, DoubleBackToCloseApp.snackBar is not shown instantly.
So, I want to add Scaffold.of(context).hideCurrentSnackBar() in _handleWillPop Function.