0.6.0 Number(someID)

CHANGELOG.md

@@ -13,3 +13,7 @@ All notable changes to the "custom-vscode-linter" extension will be documented i
 ## 0.5.0
 
 - Added more checks ever since 0.1.0, such as reminders for SQL encryption, console.log, and testing in IE.
+
+## 0.6.0
+
+- Added check for `Number(someID)`

README.md

@@ -20,6 +20,7 @@ Install it on VS Code: https://marketplace.visualstudio.com/items?itemName=hchia
     BEGIN
       -- comment: sp_password
     ```
+- `Number(someID)` would evaluate to 0 if someID is empty.
 
 ## Future work / Suggestions:
 

package.json

@@ -2,7 +2,7 @@
   "name": "custom-vscode-linter",
   "displayName": "custom-vscode-linter",
   "description": "Custom VSCode Linter!",
-  "version": "0.5.1",
+  "version": "0.6.0",
   "publisher": "hchiam",
   "repository": {
     "type": "git",

src/extension.ts

@@ -56,6 +56,7 @@ export function activate(context: vscode.ExtensionContext) {
 		check_rowCountSQL(rangesToDecorate);
 		check_encryptedSQL(rangesToDecorate);
 		check_consoleLog(rangesToDecorate);
+		check_numberOfId(rangesToDecorate);
 		activeEditor.setDecorations(decorationType, rangesToDecorate);
 	}
 
@@ -108,6 +109,13 @@ export function activate(context: vscode.ExtensionContext) {
 		genericCheck(regex, hoverMessage, popupMessage, rangesToDecorate);
 	}
 
+	function check_numberOfId(rangesToDecorate: vscode.DecorationOptions[]) {
+		let regex = /Number\((.+)?I(d|D)\)/g;
+		let hoverMessage = 'If ${match[1]} is an ID but is empty, then Number(${match[1]}) evaluates to 0.';
+		let popupMessage = 'Number(${match[1]}) evaluates to 0 if ID is empty.';
+		genericCheck(regex, hoverMessage, popupMessage, rangesToDecorate);
+	}
+
 	function genericCheck(regex: RegExp = /^$/, hoverMessage: string = '', popupMessage: string = '', rangesToDecorate: vscode.DecorationOptions[] = []) {
 		if (!activeEditor) {
 			return;

visually-check-this.js

@@ -81,3 +81,7 @@ AS--WITH ENCRYPTION
 BEGIN
 -- comment: sp_password // NO
 
+Number(someOkThing); // NO
+Number(someID); // YES
+Number(something.someId); // YES
+Number(something.someID); // YES