Skip to content

Commit

Permalink
Revert "fix(useAntdTable): reset pageSize (alibaba#2090)"
Browse files Browse the repository at this point in the history
This reverts commit 2d2cd69.
  • Loading branch information
hchlq committed Apr 27, 2023
1 parent 087f2e6 commit 315d67a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 50 deletions.
44 changes: 0 additions & 44 deletions packages/hooks/src/useAntdTable/__tests__/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,48 +232,4 @@ describe('useAntdTable', () => {
expect(queryArgs.pageSize).toBe(5);
expect(queryArgs.name).toBe('change name');
});

it('should reset params work', async () => {
queryArgs = undefined;
form.resetFields();
act(() => {
hook = setUp(asyncFn, {
form,
defaultParams: [
{
current: 1,
pageSize: 10,
},
],
});
});

const { search, tableProps } = hook.result.current;
expect(tableProps.loading).toBe(false);
await waitFor(() => expect(queryArgs.current).toBe(1));
expect(queryArgs.pageSize).toBe(10);

// change params
act(() => {
tableProps.onChange({
current: 2,
pageSize: 5,
});
});

await waitFor(() => {
expect(queryArgs.current).toBe(2);
expect(queryArgs.pageSize).toBe(5);
});

// reset params
act(() => {
search.reset();
});

await waitFor(() => {
expect(queryArgs.current).toBe(1);
expect(queryArgs.pageSize).toBe(10);
});
});
});
7 changes: 1 addition & 6 deletions packages/hooks/src/useAntdTable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,7 @@ const useAntdTable = <TData extends Data, TParams extends Params>(
if (form) {
form.resetFields();
}
_submit(
defaultParams?.[0] || {
pageSize: options.defaultPageSize || 10,
current: 1,
},
);
_submit();
};

const submit = (e?: any) => {
Expand Down

0 comments on commit 315d67a

Please sign in to comment.