Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Complete schema. #5

Closed
wants to merge 9 commits into from
Closed

Conversation

trivialfis
Copy link
Collaborator

@trivialfis trivialfis commented Dec 17, 2018

Hi @hcho3 , although this is WIP and quite early, but you are welcomed to comment on the PR if you have the time. I'm bad at writing ( isn't that obvious? ) :) , I haven't read the conversation in previous PRs and issues thoroughly so some suggestions might be missing. Will continue working on it. with a few more days I should be able to make it into shape.

The org file can be easily transformed into rst later, it's just easier for me to edit it.

@trivialfis
Copy link
Collaborator Author

trivialfis commented Dec 17, 2018

Just click view file should get you a normal GitHub style document, no need to read the diff view.

@trivialfis
Copy link
Collaborator Author

trivialfis commented Dec 20, 2018

@hcho3 The basic structure is here:

-top-level.org
-- linear-model.org
-- tree-model.org
-- objective
-- implementation-details.org

And enjoy your holiday. :)

@trivialfis
Copy link
Collaborator Author

@hcho3 I'm not sure about how to save tree nodes with adj-list. I like that idea, but how do we recover the parent field efficiently?

@trivialfis
Copy link
Collaborator Author

Okay, I think the adjacent list is doable. I will try to give a draft implementation after this PR.

@hcho3
Copy link
Owner

hcho3 commented Dec 21, 2018

The adjacency list is included in the latest version of schema.

@trivialfis trivialfis changed the title [WIP] Complete schema. Complete schema. Dec 21, 2018
@trivialfis
Copy link
Collaborator Author

trivialfis commented Dec 21, 2018

@hcho3 I added some changes to the schema. I think there will be something I miss and I'm not sure how do you want it carry this out. Can you layout some details of your plan when time allows?
For examples:

  • Do you want to implement your initial schema first now that we have two schemas?
  • If I start the initial implementation, will there be duplicated work?
  • What's your idea about utilizing adj-list, it's a representation of graph with each node pointing to each other by an index field, how should those meta data like leaf_output be saved?

And I'm looking forward to your comments since I'm working blindly. I hope that we can talk about each object one by one at some point so that we can have a common knowledge about how the complete schema should look like.

Please let me know when do you want to come back for this. I don't have Christmas so you don't need to consider my time schedule. :)

@hcho3
Copy link
Owner

hcho3 commented Jan 4, 2019

@trivialfis I think it's best to merge your suggestion into the JSON schema before implementing it. This is so that we don't duplicate work. I'll look over the proposal first.

@trivialfis
Copy link
Collaborator Author

@hcho3 Let me know when you are ready. :)

@hcho3
Copy link
Owner

hcho3 commented Mar 14, 2019

See #6

@hcho3 hcho3 closed this Mar 14, 2019
hcho3 added a commit that referenced this pull request Mar 28, 2019
* Incorporate complete schema in #5

* Do not duplicate TreeTrainParam

* fix typo

* fix more typo

* more typo

* Add JSON Schema, to address #1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants