Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to supply the classpath in a file #289

Merged
merged 4 commits into from
Sep 12, 2016
Merged

Add an option to supply the classpath in a file #289

merged 4 commits into from
Sep 12, 2016

Conversation

cargon
Copy link

@cargon cargon commented Aug 3, 2016

  • This option accepts the classpath in a file.(one element per line)
  • This mitigates the issue where you are unable to run pitest on the
    windows command line if the classpath is too big - issue Classpath too long on windows #276

Carlos Goncalves added 3 commits August 3, 2016 14:18
- This option accepts the classpath in a file.(one element per line)
- This mitigates the issue where you are unable to run pitest on the
  windows command line if the classpath is too big - issue #276
@hcoles
Copy link
Owner

hcoles commented Aug 4, 2016

Hi @cargon thanks for this.

Is this ready to take a look at merging or is there more work you intend to do? From a quick scan the new functionality doesn't look to be tested.

@cargon
Copy link
Author

cargon commented Aug 4, 2016

yes, sorry about that, I've added a test for that functionality.

@cargon
Copy link
Author

cargon commented Aug 15, 2016

Hi, @hcoles
This should be ready to merge now.
Let me know if there is anything you want me to change.

@iwarapter
Copy link

@hcoles is there any plan to merge + release this soon would be good to sort out #276 :)

@hcoles
Copy link
Owner

hcoles commented Aug 31, 2016

Might be a little while before I can cut a new release, but I'll hopefully be able to start merging pull requests again next week.

Does this PR solve #276 for you? It only adds the new option to the command line tool - it won't be available from maven etc.

@cargon
Copy link
Author

cargon commented Sep 12, 2016

We are using the gradle plugin which just wraps around the command line tool. The plan is to then add support for this to the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants