Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Improved ci #41

Merged
merged 4 commits into from Jan 19, 2016
Merged

Improved ci #41

merged 4 commits into from Jan 19, 2016

Conversation

AdrieanKhisbe
Copy link
Contributor

@hdachev
Copy link
Owner

hdachev commented Jan 19, 2016

What's the point of the code climate thing? It seems to hate the code which
is ugly as fuck but I don't see anything actionable like test coverage.
It'd be nice if it respected the jshintrc; probly a very nice tool but one
should probably start developing with it from the start, doesn't look like
it's gonna be great advertisement material for our project lol

On Tue, Jan 19, 2016 at 12:26 PM, Adrien Becchis notifications@github.com
wrote:

Have a look here of result: [image: 😃]

https://github.com/AdrieanKhisbe/fakeredis/tree/improved-ci

You can view, comment on, or merge this pull request online at:

#41
Commit Summary

  • Udpating travis build to use container and caching
  • Update CI badges
  • Upgrading dependency

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#41.

@AdrieanKhisbe
Copy link
Contributor Author

I haven't seen the result yet, gonna configure it so it rely on your jshint 😃

@AdrieanKhisbe
Copy link
Contributor Author

@hdachev
Copy link
Owner

hdachev commented Jan 19, 2016

I got a C! 💃 Nice, now I feel much better.
Thanks, this is neat stuff!

hdachev added a commit that referenced this pull request Jan 19, 2016
@hdachev hdachev merged commit 63fad15 into hdachev:master Jan 19, 2016
@AdrieanKhisbe
Copy link
Contributor Author

'C is for Cookies, that's well enough for me' =D
Le 19 janv. 2016 21:41, "Hristo Dachev" notifications@github.com a écrit :

I got a C! [image: 💃] Nice, now I feel much better.
Thanks, this is neat stuff!


Reply to this email directly or view it on GitHub
#41 (comment).

@hdachev
Copy link
Owner

hdachev commented Jan 19, 2016

Btw, if you feel like more CI hacking, setting up test coverage reporting would be an amoozing PR.
Thanks again!

@AdrieanKhisbe AdrieanKhisbe deleted the improved-ci branch January 19, 2016 21:15
@AdrieanKhisbe AdrieanKhisbe restored the improved-ci branch January 20, 2016 05:55
@AdrieanKhisbe AdrieanKhisbe deleted the improved-ci branch January 20, 2016 05:55
@AdrieanKhisbe
Copy link
Contributor Author

@hdachev -> Just send you the answer to the universe: #42
;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants