openroad: Add patch for thread-safe network in openSTA #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal-tag: [#55816] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
|
Will merge if CI passes. |
|
It seems that they bumped openSTA fork in openROAD organization: The changes haven't made their way to openROAD mainline yet. |
|
@rw1nkler Looks like they've merged The-OpenROAD-Project/OpenROAD#4712 I've created #285 to update to the latest past the STA fix. I'll close this one once I merge the other one. |
Great! Thank you! |
|
#285 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a (temporary) patch to openRAOD project that fixes problems with thread-safe concurrency in openSTA.
Those changes significantly reduce the number of
Segmentation Faulterrors on larger designs, when openROAD is run multi-threaded.The problem with thread-safe network has been well-described in The-OpenROAD-Project/OpenSTA#219 and, as has already been resolved in the openSTA mainline. However, a simple bump of openSTA submodule cannot be applied, because together with the thread-safety fixes, some additional API changes were introduced. Those additional modifications require changes in openROAD project, which may take time. This patch introduces the fixes that does not require changes in openROAD project. The patch should be removed once the openROAD adapts to thread-safe openSTA from the mainline.
CC @proppy