Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$(PYTHON3) Make variable substitution is not supported in run_shell and is not needed anyway. #284

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

allight
Copy link
Contributor

@allight allight commented Feb 29, 2024

Tested: modify xls to pull from this git and bazel build -c opt //xls/modules/rle:rle_dec_gds_sky130

…nd is not needed anyway.

Tested: modify xls to pull from this git and `bazel build -c opt //xls/modules/rle:rle_dec_gds_sky130`
@allight
Copy link
Contributor Author

allight commented Feb 29, 2024

@QuantamHD @grebe @hzeller

Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hzeller
Copy link
Collaborator

hzeller commented Feb 29, 2024

(not sure how I can trigger the CI, @QuantamHD might be able to)

@allight
Copy link
Contributor Author

allight commented Feb 29, 2024

/gcbrun was what he did before? Maybe need to have approvers.

@ericastor
Copy link
Collaborator

ericastor commented Feb 29, 2024

/gcbrun

(I believe I have approvers.)

@QuantamHD QuantamHD merged commit f449483 into hdl:main Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants