Updated Verilator to not reply on system python #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrisco
force-pushed
the
verilator
branch
7 times, most recently
from
4b7c430
to
99ca8ea
Compare
|
Running CI. Thanks for the contribution |
|
/gcbrun |
|
Can you resolve the merge conflict. Otherwise looks good |
|
@QuantamHD rebased! |
|
/gcbrun |
|
@QuantamHD Looks like CI is passing 😃 |
QuantamHD
approved these changes
Mar 3, 2024
QuantamHD
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my remote executor image I explicitly don't want
python/python3to appear on PATH and to instead rely on toolchains defined in Bazel to correctly match an interpreter. I noticed there were some genrules when building Verilator that were relying on this behavior. I've replaced the genrules used by Verilator with proper rules andpy_binarytargets to make builds more hermetic.