Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation around how to setup system to run docker build locally #31

Closed
mithro opened this issue Jun 12, 2021 · 5 comments
Closed
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@mithro
Copy link
Member

mithro commented Jun 12, 2021

https://hdl.github.io/containers/#_build explains;

A helper script is provided in .github/bin/dockerBuild to ease building images, by hiding all common options. It’s a wrapper around command build of pyHDLC.cli:

But just running the script ends up with;

tansell@tansell-glapstation:~/github/hdl/containers$ .github/bin/dockerBuild magicls
Traceback (most recent call last):
  File "/ssd/github/hdl/containers/./pyHDLC/cli.py", line 26, in <module>
    from pyAttributes.ArgParseAttributes import (

Which is clearly got something to do with missing dependencies for pyHDLC but there doesn't seem to be any instructions on how to set up things to run pyHDLC.....

@mithro
Copy link
Member Author

mithro commented Jun 12, 2021

Seems like you can do a;

virtualenv venv
source venv/bin/activate
pip install -r pyHDLC/requirements.txt

@umarcor
Copy link
Member

umarcor commented Jun 13, 2021

There is https://github.com/hdl/containers/blob/main/.github/setup.sh, which is specific for CI. However, you are correct in using a virtual environment for installing things through pip.

I'm unsure about publishing it through PyPI and/or just explicitly documenting how to use it locally. It feels rather specific to this repo, yet the pyHDLC alone can be used for building/maintaining container collections for other areas/domains. What do you think? Shall we keep it as a subdir here or shall I create umarcor/pyContainerCollections?

@mithro
Copy link
Member Author

mithro commented Jun 13, 2021

Basically you need instructions for

I just did a git clone https://github.com/hdl/containers and now I want to build the output.

It should include step-by-step instructions for installing the required dependencies and then building a given container.

@umarcor umarcor added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 13, 2021
@umarcor
Copy link
Member

umarcor commented Jun 13, 2021

There is now some documentation about how to install the dependencies and set the PATH: https://hdl.github.io/containers/dev/index.html#_utils.

@umarcor
Copy link
Member

umarcor commented May 20, 2022

There is now a section in the documentation explaining the Utils. pyHDLC commands/functions are automatically documented, and the syntax of the config YAML file is explained.

@umarcor umarcor closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants