Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning #1116

Merged
merged 7 commits into from
May 17, 2024
Merged

Fix warning #1116

merged 7 commits into from
May 17, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented May 16, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Fixed the warning regarding the TermSetWrapper being already wrapped. This shouldn't be raised when a configuration is not loaded.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (d390c14) to head (c695bd2).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1116   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          45       45           
  Lines        9760     9760           
  Branches     2771     2771           
=======================================
  Hits         8659     8659           
  Misses        779      779           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

Review Notes:
This is a possible fix to #1079. However, the pydantic error is not showing up anymore. I am going to wait to see the output of manually running run_all_tests

Update: It seems to work.

@mavaylon1 mavaylon1 marked this pull request as ready for review May 16, 2024 21:21
@mavaylon1 mavaylon1 self-assigned this May 16, 2024
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container changes look good to me. What was the reason for removing the .yaml files?

@mavaylon1
Copy link
Contributor Author

The container changes look good to me. What was the reason for removing the .yaml files?

They don't really need to be there since they can be generated when running the documentation.

@stephprince
Copy link
Contributor

Got it, would it make sense to add them to the .gitignore then if they are generated by the docs?

@mavaylon1
Copy link
Contributor Author

Got it, would it make sense to add them to the .gitignore then if they are generated by the docs?

Done. The failing hdmf-zarr test is also on schedule and seems to be unrelated to this PR.

@mavaylon1 mavaylon1 merged commit a497da3 into dev May 17, 2024
27 of 28 checks passed
@mavaylon1 mavaylon1 deleted the gallery branch May 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants