Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: ability to temporary disable rounding the images #111

Closed
AndroidDeveloperLB opened this issue Feb 25, 2016 · 10 comments
Closed

Request: ability to temporary disable rounding the images #111

AndroidDeveloperLB opened this issue Feb 25, 2016 · 10 comments

Comments

@AndroidDeveloperLB
Copy link

In some cases, instead of a circular image, I wish to show a normal image in the same area that the CircleImageView takes.
It would be nice to be able to have a "setOval(boolean)" function, which will enable&disable making the content of the CircleImageView to be rounded.
This is better than having a container of it together with a normal ImageView.

Not only that, but for drawables that exist as XML files (even those that are already round), it would be better to disable the rounding of them, instead of creating new bitmaps using getBitmapFromDrawable .

@hdodenhof
Copy link
Owner

Duplicate of #33. I'll leave this open for now and might reconsider.

@AndroidDeveloperLB
Copy link
Author

Thank you. This can be useful for avoiding creation of bitmaps, especially for the easy cases where I can create a circle drawable myself

@jonasborggren
Copy link

+1

1 similar comment
@AlexBravo
Copy link

+1

@AlexBravo
Copy link

Henning, disabling CircleImageView would be useful as a debugging feature.
With this, a developer would not have to change all xml files from CircleImageView to ImageView.

Case to consider:
I'm debugging Picasso right now, which displays its debug indicators in the corner, which is hidden by CircleImageView. So I want to disable CircleImageView together with enabling Picasso debugging in my code.

@jonasborggren
Copy link

jonasborggren commented Apr 28, 2016

In my case this would be useful for when an adapter is using the same view for slightly different rows.
Its basically for when image 1 is for a user image and image 2 is for a thumbnail.

Plus, I agree with above arguments as well. When using for example Cloudinary for making images return circular or a specific size it would be nice to be able to see exactly what's going on.

@hdodenhof
Copy link
Owner

A snapshot build of 2.1.0 with an option to disable the circular transformation is now available in the Sonatype snapshots repository.

@AndroidDeveloperLB
Copy link
Author

Is it possible to use via gradle?

@hdodenhof
Copy link
Owner

repositories {
  ...
  maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }
}

dependencies {
  compile 'de.hdodenhof:circleimageview:2.1.0-SNAPSHOT'
}

@hdodenhof
Copy link
Owner

Version 2.1.0 with this has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants