Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FixedMatrix a final class #194

Closed
HDouss opened this issue Oct 26, 2020 · 1 comment
Closed

Make FixedMatrix a final class #194

HDouss opened this issue Oct 26, 2020 · 1 comment
Labels
enhancement
Milestone
0.4

Comments

@HDouss
Copy link
Owner

HDouss commented Oct 26, 2020

FixedMatrix is not a final class, and neither it is abstract. We could make the class final. Current subclasses could encapsulate a FixedMatrix to reuse its implementation instead of subclassing FixedMatrix.
@HDouss HDouss added this to the 0.4 milestone Oct 26, 2020
HDouss added a commit that referenced this issue Oct 26, 2020
@HDouss
#194 FixedMatrix becomes final
0de42f0
@HDouss HDouss mentioned this issue Oct 26, 2020
Merged
HDouss added a commit that referenced this issue Oct 26, 2020
@HDouss
#194 catch up test coverage
998b4ab
@HDouss
Copy link
Owner Author

HDouss commented Oct 27, 2020

Resolved by PR #195

@HDouss HDouss closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@HDouss