Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type resolution #44

Closed
matildepark opened this issue May 4, 2024 · 1 comment
Closed

Fix type resolution #44

matildepark opened this issue May 4, 2024 · 1 comment

Comments

@matildepark
Copy link
Contributor

Likely introduced after #28 / #29. #39 did not fix it. This was introduced because our dependency on gluegun made it so that types needed to go into their own folder; but no matter what we seem to clobber our types, because we have both declarations and exported types (unless someone can correct me on this, I don't know TS all that well).

We probably need to remove declarationDir from tsconfig and then use a different dependency for the CLI wizard. gluegun's automatic importer basically kept choking on declarations trying to read them as commands to use. If we can stop the importer from running, and instead manually specify commands, we could probably fix this, too.

@matildepark
Copy link
Contributor Author

This should be fixed with #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant