feat(v2): acaba logo PELO AMOR DE DEUSSSSSSSSSSSSSSSSSSSSSSS #48
Conversation
Heart/Provider/Presentation/Controllers/ProvidersController.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Canhassi <80018897+Canhassi12@users.noreply.github.com>
Co-authored-by: Canhassi <80018897+Canhassi12@users.noreply.github.com>
| $this->level >= 50 => 2.0 | ||
| }; | ||
| $memberStatusMultiplier = $isSupporter ? 0.25 : 0.4; | ||
| $experienceObtained = ($states->getExperienceMultiplier() / ($this->level * $memberStatusMultiplier) * 20); |
There was a problem hiding this comment.
Fix parentheses order or remove them
| $experienceObtained = ($states->getExperienceMultiplier() / ($this->level * $memberStatusMultiplier) * 20); | |
| $experienceObtained = ($states->getExperienceMultiplier() / ($this->level * $memberStatusMultiplier)) * 20; |
| self::Disabled => 0, | ||
| self::Muted => 3, | ||
| self::Unmuted => 5, |
There was a problem hiding this comment.
As we discussed with @EduardoRFS before, using larger multipliers make easier to make subtle changes. For example, imagine you want to decrease the unmuted multiplier by 10%. We would need to work with floating numbers to make it possible.
In resume, it would be much easier to work with larger numbers, since no casting is needed.
| self::Disabled => 0, | |
| self::Muted => 3, | |
| self::Unmuted => 5, | |
| self::Disabled => 0, | |
| self::Muted => 30, | |
| self::Unmuted => 50, |
| public function getLevelAttribute(): int | ||
| { | ||
| return (new LevelEntity($this->experience))->getLevel(); | ||
| } |
There was a problem hiding this comment.
I would rather use the new accessor format. Define the level attribute on the DocBlock too, please.
| public function getLevelAttribute(): int | |
| { | |
| return (new LevelEntity($this->experience))->getLevel(); | |
| } | |
| public function level(): Attribute | |
| { | |
| return Attribute::make( | |
| get: fn () => (new LevelEntity($this->experience))->getLevel() | |
| ); | |
| } |
| { | ||
| } | ||
|
|
||
| public function persist(array $payload): void |
There was a problem hiding this comment.
I know that we don't have time for it, but it would be sick to have a ViewModel to represent this payload. Working with arrays are kinda cringe, since we don't have "proof" that the accessed value exists.
| { | ||
| } | ||
|
|
||
| public function persist(array $payload): void |
There was a problem hiding this comment.
I know that we don't have time for it, but it would be sick to have something like a VoiceMessageInput object to represent this payload. Working with arrays are kinda cringe, since we don't have "proof" that the accessed value exists.
| private ?string $country, | ||
| private ?string $state, | ||
| private ?string $city, | ||
| private ?int $zipCode, | ||
| ) { | ||
| } | ||
|
|
There was a problem hiding this comment.
I think is nice to move the creation logic to the model layer $addressModel->toEntity(). But it's just another suggestion, it's fine as it is right now.
| $response = $action->handle( | ||
| ProviderEnum::from($provider), | ||
| $request->input('provider_id'), | ||
| $request->input('username') | ||
| ); |
There was a problem hiding this comment.
What if the database is down? Shouldn't we handle this situations and define responses for them?
| ) { | ||
| } | ||
|
|
||
| public function handle() |
| ) { | ||
| } | ||
|
|
||
| public function handle(string $value, array $payload): void |
| private ?string $name, | ||
| private ?string $nickname, | ||
| private ?string $linkedinUrl, | ||
| private ?string $githubUrl, | ||
| private ?string $birthdate, | ||
| private ?string $about, |
There was a problem hiding this comment.
If your goal was to make this properties nullables, you should also define the fallback value as = null
No description provided.