Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-deterministic google-fonts outputHashes to the new correct values #3

Closed
wants to merge 1 commit into from

Conversation

kyren
Copy link

@kyren kyren commented Feb 27, 2019

No description provided.

@aszlig
Copy link
Member

aszlig commented Mar 1, 2019

Okay, I decided to diff the old and new store paths this time and the only changes are changes in comments:

--- a/fonts/home-fonts.css  2019-03-01 23:59:58.123818455 +0100
+++ a/fonts/home-fonts.css  2019-03-02 00:01:53.715131246 +0100
@@ -2,11 +2,11 @@
     font-family: 'Varela Round';
     font-style: normal;
     font-weight: 400;
-    src: url(Varela+Round_400_normal.eot); /* http://fonts.gstatic.com/s/varelaround/v10/w8gdH283Tvk__Lua32TysjIfp8uL.eot */
+    src: url(Varela+Round_400_normal.eot); /* http://fonts.gstatic.com/s/varelaround/v11/w8gdH283Tvk__Lua32TysjIfp8uL.eot */
     src: local('☺'),
-        url(Varela+Round_400_normal.eot?#iefix) format('embedded-opentype'), /* http://fonts.gstatic.com/s/varelaround/v10/w8gdH283Tvk__Lua32TysjIfp8uL.eot */
-        url(Varela+Round_400_normal.woff2) format('woff2'), /* http://fonts.gstatic.com/s/varelaround/v10/w8gdH283Tvk__Lua32TysjIfp8uP.woff2 */
-        url(Varela+Round_400_normal.woff) format('woff'), /* http://fonts.gstatic.com/s/varelaround/v10/w8gdH283Tvk__Lua32TysjIfp8uJ.woff */
-        url(Varela+Round_400_normal.ttf) format('truetype'), /* http://fonts.gstatic.com/s/varelaround/v10/w8gdH283Tvk__Lua32TysjIfp8uKLdshZg.ttf */
-        url(Varela+Round_400_normal.svg#Varela+Round_400_normal) format('svg'); /* http://fonts.gstatic.com/l/font?kit=w8gdH283Tvk__Lua32TysjIfp8uI&skey=f4466053e3923597&v=v10#VarelaRound */
+        url(Varela+Round_400_normal.eot?#iefix) format('embedded-opentype'), /* http://fonts.gstatic.com/s/varelaround/v11/w8gdH283Tvk__Lua32TysjIfp8uL.eot */
+        url(Varela+Round_400_normal.woff2) format('woff2'), /* http://fonts.gstatic.com/s/varelaround/v11/w8gdH283Tvk__Lua32TysjIfp8uP.woff2 */
+        url(Varela+Round_400_normal.woff) format('woff'), /* http://fonts.gstatic.com/s/varelaround/v11/w8gdH283Tvk__Lua32TysjIfp8uJ.woff */
+        url(Varela+Round_400_normal.ttf) format('truetype'), /* http://fonts.gstatic.com/s/varelaround/v11/w8gdH283Tvk__Lua32TysjIfp8uKLdshZg.ttf */
+        url(Varela+Round_400_normal.svg#Varela+Round_400_normal) format('svg'); /* http://fonts.gstatic.com/l/font?kit=w8gdH283Tvk__Lua32TysjIfp8uI&skey=f4466053e3923597&v=v11#VarelaRound */
 }

So I think I'll be stripping off all comments instead as a first intermediate step. I know this will not make this entirely deterministic, but I hope it should at least lower the frequency we get a hash mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants