Tweaks to get Bitescript going in JRuby 1.6.3 in --1.9 mode #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Bitescript launches under JRuby 1.6.3 with the --1.9 flag set, the following error occurs at line 307 of bytecode.rb before the input file gets parsed: TypeError: can't convert Symbol into String The issue: under --1.8, the Opcodes constant (imported from ASM) contains strings. Under --1.9, it contains symbols. This commit runs all the opcodes through to_s. Tested with both --1.8 and --1.9.
The following changes get hello_world_macro.bs running under the latest JRuby/Bitescript: * Invoke print and println with [void, object] instead of [Object] to get the correct signature * ldc 0 / aload instead of aaload 0 to access the argument array * Add a comment to make command-line usage clear
"gem build" was failing with an unrecognized time format, "YYYY-MM-DD". This commit uses "%Y-%m-%d" instead.
headius
added a commit
that referenced
this pull request
Jul 11, 2011
Tweaks to get Bitescript going in JRuby 1.6.3 in --1.9 mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits tweak Bitescript (plus its build files and examples) to work in JRuby 1.6.3 in --1.9 mode. Together, they do the following:
Fix bytecode.rb, which assumes the contents of ASM's Opcodes constant are strings (they are symbols in --1.9 mode).
Update hello_world_macro.bs to run without errors.
Update the gemspec to use a time format recognized by strftime.