Skip to content

Commit

Permalink
Merge pull request #1932 from ccolic/charts-ingressclassname
Browse files Browse the repository at this point in the history
charts: add ingressClassName to ingress template
  • Loading branch information
joaquimrocha committed May 3, 2024
2 parents bdc5d56 + 6e1f898 commit d4f7748
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions charts/headlamp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ See [MAINTAINERS.md](https://github.com/headlamp-k8s/headlamp/blob/main/MAINTAIN
| imagePullSecrets | list | `[]` | An optional list of references to secrets in the same namespace to use for pulling any of the images used |
| ingress.annotations | object | `{}` | Annotations for Ingress resource |
| ingress.enabled | bool | `false` | Enable ingress controller resource |
| ingress.ingressClassName | string | `""` | The ingress class name. Replacement for the deprecated "kubernetes.io/ingress.class" annotation |
| ingress.hosts | list | `[]` | Hostname(s) for the Ingress resource |
| ingress.tls | list | `[]` | Ingress TLS configuration |
| initContainers | list | `[]` | An optional list of init containers to be run before the main containers. |
Expand Down
3 changes: 3 additions & 0 deletions charts/headlamp/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
Expand Down
5 changes: 4 additions & 1 deletion charts/headlamp/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ ingress:
# -- Annotations for Ingress resource
annotations:
{}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"

# -- Ingress class name. replacement for the deprecated "kubernetes.io/ingress.class" annotation
ingressClassName: ""

# -- Hostname(s) for the Ingress resource
hosts:
[]
Expand Down

0 comments on commit d4f7748

Please sign in to comment.