Allow plugins to override tables #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimrocha
force-pushed
the
plugins-override-tables
branch
from
120e5ce
to
7e82e94
Compare
joaquimrocha
force-pushed
the
plugins-override-tables
branch
from
7e82e94
to
f32969c
Compare
|
Hey Joaquim, this PR works well in all our cases. Thanks. |
illume
requested changes
May 10, 2023
illume
reviewed
May 10, 2023
joaquimrocha
force-pushed
the
plugins-override-tables
branch
2 times, most recently
from
4ad647b
to
29f13dc
Compare
illume
reviewed
May 25, 2023
joaquimrocha
force-pushed
the
plugins-override-tables
branch
from
29f13dc
to
0b249b6
Compare
illume
reviewed
May 25, 2023
joaquimrocha
force-pushed
the
plugins-override-tables
branch
from
0b249b6
to
05fea7a
Compare
illume
approved these changes
May 25, 2023
When they don't use the resourceClass argument, they don't get an ID automatically set.
joaquimrocha
force-pushed
the
plugins-override-tables
branch
from
05fea7a
to
bfd5ec8
Compare
|
Love this PR. It means lot to customization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes and an example plugin on modifying existing tables throughout Headlamp.
The way this is done is by having ResourceTables identified with a new ID (or automatically done when they receive the resourceClass argument) and then plugins can declare their processors and use this ID within the processors' function to decide whether to modify the columns that the table receives.
fixes #1044