Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a phony backend token when run from Makefile #1360

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

joaquimrocha
Copy link
Collaborator

We use the make file to run Headlamp in dev mode, and since the backend token was not set up in that case, it was impossible to use this mode for testing any backend features, i.e. running npm run dev-only-app would not work for testing adding clusters, use Helm, etc.

backend/cmd/headlamp.go Outdated Show resolved Hide resolved
We use the make file to run Headlamp in dev mode, and since the
backend token was not set up in that case, it was impossible to use
this mode for testing any backend features, i.e. running
npm run dev-only-app would not work for testing adding clusters, use
Helm, etc.
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@joaquimrocha joaquimrocha merged commit b238d3a into main Sep 14, 2023
7 checks passed
@joaquimrocha joaquimrocha deleted the add-backend-token-to-dev-mode branch September 14, 2023 09:45
vyncent-t pushed a commit that referenced this pull request Sep 18, 2023
Use a phony backend token when run from Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants