-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add CNCF and verification badge to charts #42
Conversation
d6151f1
to
224bd38
Compare
@vyncent-t from our discussions... We were looking at showing the "not verified states" too. Notice the extra description, explaining what exactly each of the badges means https://artifacthub.io/packages/helm/nginx-gateway-fabric/nginx-gateway-fabric Additionally, perhaps sharing the iconography as artifact hub will make it easier for users. So they can reuse that knowledge of what icon is what? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of notes. It would also be nice if we sorted the list of charts to show them in this order:
- CNCF
- Official
- Verified
- rest
I updated the visuals to match those of artifact hub with matching labels for non verified and others @illume |
224bd38
to
25e0e5c
Compare
Is it just me or does it look a bit too "busy"? A lot of different colors makes it a bit hard to parse visually. What if we kept the icons only when the app is "verified", "official", etc and kept them monochrome at all times? Something like this: doesn't have to be changed within this PR, we can discuss and iterate later |
I agree with @illume that we should keep the icons aligned with ArtifactHub, meaning that a star would be for official, and a check mark for verified, but we can use different icons and in the monochromatic version as @sniok said. The important thing is to make sure users can have direct access to an official Nginx chart, before they even see any unofficial versions. That's why the sorting is so important. In a different PR we should also not show unofficial charts unless the user specifically toggled a switch to include those in the plugin settings. |
9673cae
to
3ca4bad
Compare
noticed in some places artifact hub will use either chart.cncf or chart.repository.cncf on their icons to choose to display so I implemented that |
c8c8365
to
8401a94
Compare
Signed-off-by: Vincent T <vtaylor@microsoft.com>
8401a94
to
e075acc
Compare
I have reduced the size of the cncf icon slightly + made the official badge appear first, as we had chatted (most important to least important). |
Enhance App Catalog with ArtifactHub Badges
Description
fixes issue #20
This PR aims to enhance our app catalog by incorporating important badges from ArtifactHub. These badges indicate whether an app is official, verified, or a CNCF project. Displaying these badges will help users make informed decisions about which packages to install, ensuring they opt for secure and verified applications.
Changes
Verification
Images