fix: improved non token supported device handling #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
jlipps
approved these changes
May 21, 2024
| throw new Error(`Could not retrieve token; please try allowing the remote again`); | ||
| } | ||
|
|
||
| console.log('The device may not token supported device. Allowing the notification is sufficient.'); // eslint-disable-line no-console |
There was a problem hiding this comment.
Suggested change
| console.log('The device may not token supported device. Allowing the notification is sufficient.'); // eslint-disable-line no-console | |
| console.log('The device may not support token-based authentication. Allowing the pop-up notification is sufficient.'); // eslint-disable-line no-console |
| * @param {any} jsonBody | ||
| * @returns {'true'|'false'|undefined} | ||
| */ | ||
| _getTokenSupportDevice(jsonBody) { |
There was a problem hiding this comment.
Suggested change
| _getTokenSupportDevice(jsonBody) { | |
| _getDeviceSupportsTokens(jsonBody) { |
maybe?>
| throw new Error(`Could not get token; server responded with: ${format('%O', res)}`); | ||
| } | ||
| this.#debug('The device may not support token as old model.'); | ||
| return undefined; |
There was a problem hiding this comment.
Suggested change
| return undefined; | |
| return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isTokenSupportedDeviceto check if the device supports token