Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal #27

Closed
6 tasks
aVileBroker opened this issue May 6, 2020 · 0 comments
Closed
6 tasks

Modal #27

aVileBroker opened this issue May 6, 2020 · 0 comments
Labels
1 Story Point Story points: 1 new component New base component
Projects
Foundry-react-UI HS-Angular-UI

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented May 6, 2020 •
edited

  • Implement base UI
  • Fully themable
  • Add story with meaningful knobs
  • Add figma frame to story
  • A11y compliance
  • Unit/snapshot testing

Figma board:
https://www.figma.com/file/3r2G00brulOwr9j7F6JF59/Generic-UI-Style?node-id=102%3A14
Modal

Sub-components

  • ClickTrap
  • Card
  • CloseButton

API:

  • onClickOutside
  • onClose
  • header
  • body
  • footer
  • background-blur
  • background-darkness
@aVileBroker aVileBroker created this issue from a note in Foundry-react-UI (Backlog) May 6, 2020
@aVileBroker aVileBroker added 1 Story Point Story points: 1 new component New base component labels May 6, 2020
@aVileBroker aVileBroker moved this from Backlog to Priority to do in Foundry-react-UI May 7, 2020
@aVileBroker aVileBroker moved this from Priority to do to Done in Foundry-react-UI May 15, 2020
vlineros referenced this issue in vlineros/hs-ui May 29, 2020
@vlineros-HS
#27 added input for label and icon that changes based on valid/requir…
85d47ba 
…ed props
vlineros referenced this issue in vlineros/hs-ui May 29, 2020
@vlineros-HS
#27 added color changes on validity and a boolean to turn valid check…
a960a03 
…ing on and off
vlineros referenced this issue in vlineros/hs-ui May 29, 2020
@vlineros-HS
#27 added ability to use different colors for valid/invalid and switc…
45253ef 
…hed to better font for basic
vlineros referenced this issue in vlineros/hs-ui May 29, 2020
@vlineros-HS
#27 added bigger font for basic label
d4760c3
vlineros referenced this issue in vlineros/hs-ui Jun 3, 2020
@vlineros-HS
#27 addressing PR review comments except valid changes, font body, te…
20e4538 
…xtinput as child
@aVileBroker aVileBroker added this to Backlog in HS-Angular-UI via automation Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Story Point Story points: 1 new component New base component
Projects
No open projects
Foundry-react-UI
  
Done
HS-Angular-UI
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aVileBroker