Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build system to earthly #81

Merged
merged 5 commits into from Aug 15, 2022
Merged

Switch build system to earthly #81

merged 5 commits into from Aug 15, 2022

Conversation

ellenhp
Copy link
Member

@ellenhp ellenhp commented Aug 12, 2022

This also paves the way for further productionization because the init containers do a lot of the heavy lifting, extracted data is persisted (the whole postgres dump isn't imported into nominatim on each start anymore), serving containers start faster, and a bunch of other cool things.

Hope you like churn because pretty much everything got renamed.

Still to do:

  • Update docs
  • Update readme
  • Copy the list of cities we support to a file somewhere to replace make list
  • Verify transit still works (it probably doesn't realistically speaking)
  • Get transit working (if it doesn't still work)

And it would be good to have a test plan to avoid more regressions.

Test plan:

  • Check base-map functionality
  • Check search auto-complete
  • Check clicking on search results
  • Check car routing
  • Check bike routing
  • Check walking routing
  • Check transit routing

@ellenhp ellenhp marked this pull request as draft August 12, 2022 01:51
@ellenhp
Copy link
Member Author

ellenhp commented Aug 12, 2022

Looks like Earthly doesn't handle copy-on-write which is a bummer because that means it'll keep several copies of planet.osm.pbf around, and worse still several copies of the nominatim and photon indices. :/

See: earthly/earthly#2097

@ellenhp
Copy link
Member Author

ellenhp commented Aug 13, 2022

To close the loop on the multiple-copies issue, this is a problem but ZFS with duplication makes it a non-issue. VDO would probably do the same. It's also only really an issue with planet-scale builds from what I've seen.

@ellenhp ellenhp marked this pull request as ready for review August 13, 2022 22:41
@ellenhp
Copy link
Member Author

ellenhp commented Aug 15, 2022

I'm going to merge this but feel free to comment here with ways we could improve the new build system.

@ellenhp ellenhp merged commit 39e0cb2 into headwaymaps:main Aug 15, 2022
@ellenhp ellenhp deleted the earthly branch August 15, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant