You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Love the module, thanks for working on it. I have one peeve I want to share with you, because it cost me two hours of debugging today:
I would be very happy if you could make the documentation on coordinate systems more clear throughout. Many of the functions (e.g., visufunc.mollview) have a coordinate keyword that uses 'E', 'G', and 'C' as shorthand for the coordinate systems and to set up transformations -- this functionality is great. What's missing is clarifying what those 3 stand for. I, naively, assumed 'E' was for 'Equatorial', and used 'EG' to try to convert my equatorial-coordinate data to Galactic coordinates, and was stumped for why the output positions were wrong.
Digging through the documentation (after two hours of eliminating all other possible sources of error), the ONLY place I could find the shorthands explained was in the docstring for fitsfunc.write_map (a function I've never needed, and so otherwise would not have looked at); this finally let me solve my problem. It would be fantastic if you could propagate this information throughout the documentation (e.g., other docstrings that use this convention, such as visufunc.mollview), so that others don't fall into the same confusion as I did.
Thanks very much,
Cameron Van Eck
The text was updated successfully, but these errors were encountered:
thanks for reporting!
this is a good documentation improvement project someone could contribute via a Pull Request to the project. If anyone is volunteering please notify me here.
@zonca, I would love to work on improving the documentation. I will start with visualization functions like visufunc.mollview and projection functions related to them.
Hello!
Love the module, thanks for working on it. I have one peeve I want to share with you, because it cost me two hours of debugging today:
I would be very happy if you could make the documentation on coordinate systems more clear throughout. Many of the functions (e.g.,
visufunc.mollview
) have a coordinate keyword that uses 'E', 'G', and 'C' as shorthand for the coordinate systems and to set up transformations -- this functionality is great. What's missing is clarifying what those 3 stand for. I, naively, assumed 'E' was for 'Equatorial', and used 'EG' to try to convert my equatorial-coordinate data to Galactic coordinates, and was stumped for why the output positions were wrong.Digging through the documentation (after two hours of eliminating all other possible sources of error), the ONLY place I could find the shorthands explained was in the docstring for
fitsfunc.write_map
(a function I've never needed, and so otherwise would not have looked at); this finally let me solve my problem. It would be fantastic if you could propagate this information throughout the documentation (e.g., other docstrings that use this convention, such asvisufunc.mollview
), so that others don't fall into the same confusion as I did.Thanks very much,
Cameron Van Eck
The text was updated successfully, but these errors were encountered: