Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on coordinate systems #841

Open
Cameron-Van-Eck opened this issue Apr 12, 2023 · 2 comments
Open

Improve documentation on coordinate systems #841

Cameron-Van-Eck opened this issue Apr 12, 2023 · 2 comments
Labels
Good first issue Relatively small patch that doesn't require an in-depth understanding of healpy HelpUs

Comments

@Cameron-Van-Eck
Copy link

Hello!

Love the module, thanks for working on it. I have one peeve I want to share with you, because it cost me two hours of debugging today:

I would be very happy if you could make the documentation on coordinate systems more clear throughout. Many of the functions (e.g., visufunc.mollview) have a coordinate keyword that uses 'E', 'G', and 'C' as shorthand for the coordinate systems and to set up transformations -- this functionality is great. What's missing is clarifying what those 3 stand for. I, naively, assumed 'E' was for 'Equatorial', and used 'EG' to try to convert my equatorial-coordinate data to Galactic coordinates, and was stumped for why the output positions were wrong.

Digging through the documentation (after two hours of eliminating all other possible sources of error), the ONLY place I could find the shorthands explained was in the docstring for fitsfunc.write_map (a function I've never needed, and so otherwise would not have looked at); this finally let me solve my problem. It would be fantastic if you could propagate this information throughout the documentation (e.g., other docstrings that use this convention, such as visufunc.mollview), so that others don't fall into the same confusion as I did.

Thanks very much,
Cameron Van Eck

@zonca zonca added Good first issue Relatively small patch that doesn't require an in-depth understanding of healpy HelpUs labels Apr 14, 2023
@zonca
Copy link
Member

zonca commented Apr 14, 2023

thanks for reporting!
this is a good documentation improvement project someone could contribute via a Pull Request to the project. If anyone is volunteering please notify me here.

@xli2522
Copy link

xli2522 commented Apr 11, 2024

@Cameron-Van-Eck The three coordinates are

coordname = {"G": "Galactic", "E": "Ecliptic", "C": "Equatorial"}

@zonca, I would love to work on improving the documentation. I will start with visualization functions like visufunc.mollview and projection functions related to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Relatively small patch that doesn't require an in-depth understanding of healpy HelpUs
Projects
None yet
Development

No branches or pull requests

3 participants