Fix message count (discussion) #87
Conversation
…ucture, because the signalling mechanism doesn't work reliably with this approach
|
Yes, that's what I suspected, but I had plans in the future for allowing more than just 2 validators - using a remote server, or different versions of the Java validators, hence why I went with the class... I agree it's probably stressing Qml.Net too much and we need to report this as an issue. Haven't created an explicit test case to submit to the project yet. I agree with this change. |
|
That's what I suspected ;) |
|
Maybe it's best just to use a simple approach for now and deal with the more complex situation in a proper way when it becomes relevant? I think it can be done but it needs some TLC. |
|
TLC? But yes, I agree on the simpler approach for now. |
|
I tried a struct initially because that made most sense with my C++ background but things were very weird with them: qmlnet/qmlnet#135 😅 |
|
Tender Loving Care I believe ;) Wow, that's a weird issue. But the class approach isn't working very well either ... |
|
Fixes #39 |
…ucture, because the signalling mechanism doesn't work reliably with this approach
…Hammer into fix-message-count
Hi Vadim, I noticed that the error/warning count wouldn't always get communicated to the QML side, and then I found your comment about setting the warning count before the error count. I believe your original approach with a general class that gets instantiated is not really compatible with the way Qt/QML signalling works, or at least stresses what it's supposed to do.
Since the ValidationResult is a really simple structure with three elements that gets used just twice, maybe it is best just to write these six resulting elements out directly, like below. This works reliably.
Another approach that works is to first instantiate a new ValidationResult, then set its properties and then bind it to the property that QML can access. But this doesn't allow for changing properties of this object afterwards in any reliable way. Alternatively, you can expand it with explicit signals, but that makes things quite complicated.