-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a curl example in PHP example section #384
Comments
curl is a very common used php module but not installed when you install php on Debian.
my uneducated guess would around about a minute.
Nope but it could fail to connect in the same ways curl could which is not checked by this code. |
There is a php-curl module (https://www.php.net/manual/en/book.curl.php) but my example use a complete different library: https://github.com/php-curl-class/php-curl-class that looked convenient to me (install through composer + retry option).
no the library chose a different pattern php-curl-class/php-curl-class#403 What I was trying to say by "updating the doc", was not something specific to php but maybe a section on those options (timeout + retry) in general. Then each langage specific page could give insight on how to do it. It could be great to mention multiple solutions, for php I'd keep mentionning "file_get_contents" but adding "curl" + options |
If you need snippet :
|
That's a good idea! I've started work on the general page. Current version live here: https://healthchecks.io/docs/reliability_tips/ I'm confident I can also update Python examples, but for other languages help is very welcome. |
the new page is great. Tried to update the php example here #395, hope it will help ... |
@smknstd thanks for the PR, looks good! I noticed just now that PHP samples have no syntax highlighting. Related issue: Python-Markdown/markdown#334 I will keep an eye on python-markdown releases. |
Suggested here: https://twitter.com/smknstd/status/1272818956076810247
Aside from the code sample, it will need some accompanying information–
I'm very out of touch of today's PHP, so would appreciate any help.
The text was updated successfully, but these errors were encountered: