Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration stay red until next message is send even if test succeeds #391

Closed
SuperSandro2000 opened this issue Jun 30, 2020 · 4 comments
Closed

Comments

@SuperSandro2000
Copy link
Contributor

I am self hosting my healthchecks and after a connectivity issue a few of my integrations are red. They didn't turn back green when I tested them to see if they are working. I think this should be added cause they should not stay red until the next real alarm is send.

@cuu508 cuu508 closed this as completed in 3a00c0d Jul 1, 2020
@cuu508
Copy link
Member

cuu508 commented Jul 1, 2020

Thanks for the suggestion, makes sense.

I changed how the "Test!" button works:

  • sending test notification now creates a Notification object, same as for normal notifications. Consequently, sending a test notification now updates the "Status" and "Last Notification" columns in the Integrations page:

image

  • sending a test notification now updates (sets or clears) the Channel.last_error field. This is what determines if we show the red exclamation sign in top nav or not.

@SuperSandro2000
Copy link
Contributor Author

Thanks!

Does this also mean both notification are send from the same process?

@cuu508
Copy link
Member

cuu508 commented Jul 1, 2020

No, normal notifications are sent by the manage.py sendalerts process. Test notifications are sent by the web server process while handling the HTTP request.

@SuperSandro2000
Copy link
Contributor Author

Good to clarify that. I noticed this error initially while debugging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants