Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grace Time not completely editable once a job is created #945

Closed
saschabrockel opened this issue Jan 22, 2024 · 1 comment · Fixed by #953
Closed

Grace Time not completely editable once a job is created #945

saschabrockel opened this issue Jan 22, 2024 · 1 comment · Fixed by #953

Comments

@saschabrockel
Copy link

image
Images can say more than words.

You can see that I want to change the grace time here but it's just possible to change it completely on creation. I cannot change the field from minutes to hours or anything else. It is not a button. It would be lovely to be able to edit this because recreation means another ID and changes in the script/app or whatever.

@cuu508
Copy link
Member

cuu508 commented Jan 22, 2024

You can set it to 120 to get two hours, to 180 to get three hours, etc.

I will accept a PR which turns the minutes part into a dropdown, if:

  • the end result looks good visually (both in light and dark mode)
  • the code changes are not big, and it does not introduce new dependencies
  • the dropdown works well with keyboard navigation

mickBoat00 added a commit to mickBoat00/healthchecks that referenced this issue Feb 6, 2024
mickBoat00 added a commit to mickBoat00/healthchecks that referenced this issue Feb 8, 2024
cuu508 pushed a commit that referenced this issue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants