Add support for Unity PM API, update nokogiri to ~>1.6 (for rails 4.2 compatibility) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'll find some time to review the changes and work on integrating this into a new version. |
|
are you guys interested in merging this in to support the PM API? |
|
Yes. Sorry, I will try to find some time. We don't currently integrate with PM and I need to get setup in that sandbox in order to test and look over the change request. |
Conflicts: allscripts_unity_client.gemspec spec/json_client_driver_spec.rb
bmishkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of hacking on the gem at the Allscripts Unity PM Workshop today.
This adds some simple switches to allow usage of the PM API, and a few other fixes.
Along with the rspecs, I've tested this using the sandbox PM environment on-site at Allscripts.